Use a separate context when handling multiprocessing calls #2006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue sherpa#1015 and provides the sherpa.utils.parallel.context field for code that wants to use Sherpa's multiprocessing setup.
We don't need to send in the queues and lock since we can take them from the existing context (i.e. local variables).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
+ Coverage 83.18% 83.21% +0.03%
==========================================
Files 81 81
Lines 28294 28293 -1
Branches 4368 4368
==========================================
+ Hits 23536 23544 +8
+ Misses 4648 4639 -9
Partials 110 110
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
hamogu
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that Sherpa does not change the global multiprocessing state but instead uses the (new)
sherpa.utils.parallel.contextattribute. Fix #1015.Details
The multiprocessing documentation states, within https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods
This PR does this, making the context available as
sherpa.utils.parallel.context.I also made a small change to a callback routine since we don't need to send in the queues and lock since they are already ambient pieces of information (I do note that this is not great if we use spawn/forkserver but there are so many other issues there that I am working on that it's not an issue here - we can follow #2007 for that).
The coverage checks are not great because we do not actually run the multiprocessing code in our CI runs as thy tend to be run using an environment that only provides a single core, hence has no multiprocessing support.