Feature/1 6 1 #79
Feature/1 6 1 #79
Conversation
- updated Hough/SimpleThreshold implementations.
…ector invocation.
… with validation before detector execution.
…lt, including recommended extras keys and the expectation to keep lines empty when not applicable.
…ent numpy/torch/PIL compatibility.
…ROI masks with `ensure_numpy` in the default detectors.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| metadata=metadata, | ||
| ) | ||
| context = _normalize_detection_context(context) | ||
| result = det.detect(context) |
There was a problem hiding this comment.
Preserve legacy detector signature support
In process_image_batch, the pipeline now always calls det.detect(context) with a single DetectionContext argument and does not attempt to fall back to the legacy detect(current_image, previous_image, roi_mask, params) signature. Any existing v1.6.0 detector that still implements the old signature will raise TypeError, which is caught as a generic exception and treated as a failed detection for every frame, effectively disabling those plugins despite the stated backward compatibility. Consider dispatching based on the detect signature (or catching TypeError to call detect_legacy) to keep older plugins working.
Useful? React with 👍 / 👎.
No description provided.