Docs: Update Theme Logic #1491
Merged
Docs: Update Theme Logic #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the theme system logic to handle different page types dynamically and adds Turbo navigation support. The changes centralize theme initialization logic and ensure proper theme handling during page transitions.
- Refactored theme logic to conditionally handle site pages vs. regular pages with different stylesheets
- Added Turbo navigation event listener to reinitialize themes on page transitions
- Removed duplicate theme initialization script from base template
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/webawesome/docs/assets/scripts/theme.js | Added conditional logic for site pages, Turbo support, and centralized theme initialization |
| packages/webawesome/docs/_includes/base.njk | Removed inline theme initialization script |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b1c7420 to
232b32a
Compare
* theming logic is handled by theme.js and theme-selector.njk, mmkay?
232b32a to
45db8d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the theme system logic to handle different page types dynamically and adds Turbo navigation support. The changes centralize theme initialization logic and ensure proper theme handling during page transitions.