Round --content-width-* and use in the docs
#1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
talbs
approved these changes
Oct 1, 2025
| --content-width-s: 80ch; | ||
| --content-width-xs: 50ch; | ||
| /* max-width for fixed width app-based pages | ||
| * We round() these to avoid obscure component rendering bugs caused by widths with fractional pixels */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--content-width-*properties to useround()so that resulting values are always whole pixels to prevent the odd rendering bug like we previously had for<wa-scroller>(see Scroller component #907 (review) and Fix focus ring in<wa-scroller>,<wa-dialog>, and<wa-drawer>#1525 for context)--content-width-*and--line-length-*for our docs pages