-
Notifications
You must be signed in to change notification settings - Fork 96
Add link to Figma Design Kit doc #1544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
talbs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work adding this.
I left some thoughts on both where to link and the step-icon utility inline. Let me know what you think on each and if you want to chat anything out.
talbs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great success! Get on the road and 🚚 this to Mergeburgh!
| } | ||
|
|
||
| /* step icons for ordered instructions */ | ||
| .step-icon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📶 💪
| } | ||
| } | ||
|
|
||
| /* Images & Figures */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
| <strong>Need a hand?</strong> | ||
| <wa-button size="small" appearance="filled" variant="neutral" href="https://github.com/shoelace-style/webawesome/issues" target="_blank"> | ||
| <wa-icon slot="prefix" name="bug"></wa-icon> | ||
| <wa-icon slot="start" variant="regular" name="bug"></wa-icon> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
| </wa-button> | ||
| <wa-button size="small" appearance="filled" variant="neutral" href="https://github.com/shoelace-style/webawesome/discussions" target="_blank"> | ||
| <wa-icon slot="prefix" name="message-question"></wa-icon> | ||
| <wa-icon slot="start" variant="regular" name="message-question"></wa-icon> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Equally nice fix!
Relies on https://github.com/shoelace-style/webawesome-pro/pull/58
@talbs, mind letting me know your thoughts on:
.step-iconstyles belong inutils.css?I figure
.step-iconwould be good to use in the 2FA flow too, which I can make a quick PR to update if everything's kosher.