Allow required indicator to be targetable #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
talbs
approved these changes
Oct 17, 2025
Contributor
talbs
left a comment
There was a problem hiding this comment.
Works as intended! Thanks for the quick fix. 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1486, we updated our internal form control styles so that the value of
--wa-form-control-required-content-offsethad expected results across all form control components. This involved changing our selector to applied required content fromparts toslots.However, slots in the shadow DOM aren't inherently style-able from the light DOM. This means that there was no way to target the
::afterpseudo-selector generating the required indicator. (see @talbs for the resulting pain and suffering)This change does two things:
partselectors for the required indicator so that it's targetable in light DOM styles via::part(form-control-label)::afteror::part(label)::after, depending on the componentdisplay: inline-flex;for labels to avoid the heinous, enigmatic extra whitespace inherent toinline-block, which was bloating the space between the label text and required indicator for some componentsI accept all warranted shunning for suggesting the last fix that in turn caused this issue.