Add dynamic config#200
Open
fvaleri wants to merge 4 commits into
Open
Conversation
Add mirror.num.replica.fetchers and mirror.metadata.refresh.interval.ms to AllDynamicConfigs and introduce a DynamicClusterMirrorConfig handler that validates and applies changes at runtime without broker restart. For mirror.num.replica.fetchers, MirrorFetcherManager overrides resizeThreadPool to redistribute existing partitions across the new thread count. For mirror.metadata.refresh.interval.ms, ClusterMirrorCoordinator stores the ScheduledFuture returned by the scheduler and exposes rescheduleMetadataRefresh which cancels the old periodic task and schedules a new one with the updated interval. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Collaborator
Author
|
KIP updated. Tested manually and it seems to work fine. ================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.14.0
session_id: 2026-06-12--003
run time: 20 minutes 27.814 seconds
tests run: 24
passed: 24
flaky: 0
failed: 0
ignored: 0
================================================================================ |
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
showuon
reviewed
Jun 15, 2026
showuon
left a comment
Owner
There was a problem hiding this comment.
The change makes sense to me. But have you tested locally at least to update these 2 configs dynamically?
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Collaborator
Author
Quoting myself: "Tested manually and it seems to work fine." |
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mirror.num.replica.fetchers and mirror.metadata.refresh.interval.ms to AllDynamicConfigs and introduce a DynamicClusterMirrorConfig handler that validates and applies changes at runtime without broker restart.
For mirror.num.replica.fetchers, MirrorFetcherManager overrides resizeThreadPool to redistribute existing partitions across the new thread count.
For mirror.metadata.refresh.interval.ms, ClusterMirrorCoordinator stores the ScheduledFuture returned by the scheduler and exposes rescheduleMetadataRefresh which cancels the old periodic task and schedules a new one with the updated interval.