fix: fix outdir and workdir on commands #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37d6948 to
1f67ff7
Compare
1f67ff7 to
7cd2520
Compare
Contributor
Author
|
@ralgozino could you do a test of |
ralgozino
approved these changes
Oct 7, 2024
Member
ralgozino
left a comment
There was a problem hiding this comment.
The 3 commands now respect the outdir when passed and do not use the $HOME/.furyctl folder anymore 🎉
I also tested setting --outdir and --workdir at the same time and everything seems to be working as expected.
well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
get kubeconfig,get upgrade-pathsandrenew certificatescommands.