Update sharding for metrics and tinkey #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hayden <haydentherapper@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 35.52% 35.49% -0.04%
==========================================
Files 43 43
Lines 3153 3153
==========================================
- Hits 1120 1119 -1
- Misses 1929 1930 +1
Partials 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jku
previously approved these changes
Aug 4, 2025
Member
jku
left a comment
There was a problem hiding this comment.
looks good to me. Left a comment on usage of "DER" that I guess I missed in the original PR
Signed-off-by: Hayden <haydentherapper@users.noreply.github.com>
jku
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a step to set up the monitoring (which can likely be applied earlier in the process, for now we'll do it after spinning up the service) and switching to using a script for generating Tink keysets