-
Notifications
You must be signed in to change notification settings - Fork 16
Export Tessera Open Telemetry metrics #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 35.49% 35.07% -0.42%
==========================================
Files 43 44 +1
Lines 3153 3193 +40
==========================================
+ Hits 1119 1120 +1
- Misses 1930 1969 +39
Partials 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cpanato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
loosebazooka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's been a while since I looked at how otel works, so I'll defer to you, but I'll also go refresh.
cmd/rekor-server/app/otel.go
Outdated
| shutdown := func(ctx context.Context) { | ||
| if err := mp.Shutdown(ctx); err != nil { | ||
| slog.Error(fmt.Sprintf("error shutting down meter provider: %v", err)) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be the one os.Exit'ing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I guess not, fixed
Tessera includes Open Telemetry instrumentation. This change sets up an exporter to automatically have Tessera metrics collected in GCP. This ignores Traces for now. Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Tessera includes Open Telemetry instrumentation. This change sets up an exporter to automatically have Tessera metrics collected in GCP. This ignores Traces for now.
Partial #225
Requires sigstore/terraform-modules#69 before deployment.
Summary
Release Note
Documentation