Skip to content

Conversation

@cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Aug 5, 2025

Tessera includes Open Telemetry instrumentation. This change sets up an exporter to automatically have Tessera metrics collected in GCP. This ignores Traces for now.

Partial #225

Requires sigstore/terraform-modules#69 before deployment.

Summary

Release Note

Documentation

@cmurphy cmurphy requested review from a team as code owners August 5, 2025 22:37
@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.07%. Comparing base (a013a68) to head (538521f).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/rekor-server/app/otel.go 0.00% 37 Missing ⚠️
cmd/rekor-server/app/serve.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   35.49%   35.07%   -0.42%     
==========================================
  Files          43       44       +1     
  Lines        3153     3193      +40     
==========================================
+ Hits         1119     1120       +1     
- Misses       1930     1969      +39     
  Partials      104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cpanato
cpanato previously approved these changes Aug 6, 2025
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's been a while since I looked at how otel works, so I'll defer to you, but I'll also go refresh.

shutdown := func(ctx context.Context) {
if err := mp.Shutdown(ctx); err != nil {
slog.Error(fmt.Sprintf("error shutting down meter provider: %v", err))
os.Exit(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be the one os.Exit'ing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I guess not, fixed

Tessera includes Open Telemetry instrumentation. This change sets up
an exporter to automatically have Tessera metrics collected in GCP. This
ignores Traces for now.

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
@cmurphy cmurphy merged commit ed3c874 into sigstore:main Aug 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants