feat(ag-grid): support element theming for ag-grid #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mistrykaran91
commented
Dec 16, 2025
- I confirm that this MR follows the contribution guidelines.
|
Documentation. Coverage Reports: |
kfenner
reviewed
Dec 16, 2025
| params: { | ||
| // size: | ||
| buttonFontWeight: '600', | ||
| cellFontFamily: '"SiemensSans Pro VF", sans-serif', |
Member
There was a problem hiding this comment.
I think we should use the variable here from simpl/brand
Member
Author
There was a problem hiding this comment.
@kfenner: I'm now using this variable var(--element-body-font-family), hope this one is correct ?
… for improved theming
…ed theming consistency
…styles for consistency
…proved Element theming
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.