llm-tool-collection-deftool: declare indent, doc-string and support for async tool #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! I'm not too familiar with the font-lock and Imenu stuff. @ultronozm, would you mind taking a glance at this? |
Contributor
|
Looks fine to me except for the font-lock removal - I think I added that, and I seem to recall one of the points being to make fontification work well even before the package is loaded (e.g., on startup). So perhaps @kiennq could add some further motivation for that |
Contributor
|
I'm also curious about the |
Owner
|
Hmm, I'm going to go ahead and merge the other changes for now. I would like to have support for async tools, I think some of the current tools are better suited to being async. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly declare the indent and doc-string index for
llm-tool-collection-deftoolRemove some autoload tag and font lock since it will be handled correctly after the
llm-tool-collectionsis loaded.And finally add support for async tool, where the body can take and
callback-fnto notify the result back in async way to LLM