[ENH] scitype coercion and checking utility #6969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
FYI @Alex-JG3, @RikStarmans, @benHeid, @yarnabrina |
Collaborator
Author
|
ready for review |
benHeid
pushed a commit
to Z-Fran/sktime
that referenced
this pull request
Oct 3, 2024
This PR introduces a scitype coercion and checking utility in the `registry` module, base functionality towards sktime#6892. The intended use is in the `__init__` of estimators, allowing polymorphic composites. From a specification perspective, if used systematically, this would: * remove any user need to use adapters such as `TabularTransformAdaptor` * enable simpler specification where there is a single or most prominent reduction, such as various annotation subtypes to transformation, or time series aligner to time series distance Replaces existing coercion or composition logic in some transformer related instances: * transformation pipeline dunders * compositors `OptionalPassthrough`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a scitype coercion and checking utility in the
registrymodule, base functionality towards #6892.The intended use is in the
__init__of estimators, allowing polymorphic composites. From a specification perspective, if used systematically, this would:TabularTransformAdaptorReplaces existing coercion or composition logic in some transformer related instances:
OptionalPassthrough