Update Metro @Assisted inject support #2150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change set updates the codegen module to create a Presenter's factory with a Factory class annotated with Metro's @AssistedFactory. This enables a `Navigator` and `Screen` instance to be used as runtime injected parameters for the creation of a presenter in Metro projects.
|
Thanks for the contribution! Before we can merge this, we need @aaalaniz to sign the Salesforce Inc. Contributor License Agreement. |
|
I discovered this in a toy project in this PR and verified it works locally, but let me know if something is incorrect here! 🙏🏼 |
|
let me know when you've signed the CLA and I can rejig the status check |
Cool, should be signed now. Thank you 🙏🏼 |
|
The way to rejig it is to close and reopen the PR, because we are a serious company |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set updates the codegen module to create a Presenter's factory with a Factory class annotated with Metro's @AssistedFactory. This enables a
NavigatorandScreeninstance to be used as runtime injected parameters for the creation of a presenter in Metro projects.