Skip to content

Fix reset root crash when using the gesture navigation decoration #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2025
Merged

Fix reset root crash when using the gesture navigation decoration #2206

merged 5 commits into from
Jul 25, 2025

Conversation

@stagg
Copy link
Collaborator

@stagg stagg commented Jul 25, 2025 •
edited
Loading

Fixes #2153

Bug

  • The AndroidPredictiveBackNavDecorator had a bug in it where the predictiveBackMotion around the content was getting recomposed for changes in enabled and isSeeking.
  • This was resulting in late composition applications that would result in the reused record saveable state holder getting added back right before being removed.

Fix

  • First fix is to be a bit more defensive when building the content providers in NavigableCircuitContent by checking a depth of 2
  • Second fix was to make enabled and isSeeking lambdas that get read within the graphicsLayer

@stagg stagg marked this pull request as ready for review July 25, 2025 21:47
@stagg stagg enabled auto-merge July 25, 2025 21:47
@stagg stagg requested a review from ZacSweers July 25, 2025 21:47
ZacSweers
ZacSweers approved these changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test!

@stagg stagg added this pull request to the merge queue Jul 25, 2025
Merged via the queue into main with commit d47b7db Jul 25, 2025
5 checks passed
@stagg stagg deleted the j-fix-gesture-resetroot branch July 25, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZacSweers ZacSweers ZacSweers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash when switching tabs + gesture navigation

3 participants

@stagg @ZacSweers