Fix SqlLogger syslog decoding for VariableValue payloads#1146
Merged
Conversation
Update the SqlLogger class to unwrap JSON payloads from VariableValue objects before decoding syslog entries. This change ensures proper handling of log entries, improving the reliability of the logging functionality within the PyRogue framework.
ruck314
approved these changes
Mar 18, 2026
Contributor
|
@bengineerd Should be entry.value (instead of entry[]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
SqlLogger syslog handling decoded
VariableValue, not the underlying JSON stringWhat was broken:
SystemLogLastarrived asVariableValue, but the logger passed that wrapper tojson.loads().Inputs that triggered it:
SystemLogLastupdate routed into SQL logging.Result:
Fix: