Skip to content

Fix SqlLogger syslog decoding for VariableValue payloads#1146

Merged
bengineerd merged 4 commits into
pre-releasefrom
bugfix/sql-logger-syslog
Mar 26, 2026
Merged

Fix SqlLogger syslog decoding for VariableValue payloads#1146
bengineerd merged 4 commits into
pre-releasefrom
bugfix/sql-logger-syslog

Conversation

@bengineerd

@bengineerd bengineerd commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Bug Fixes

  1. SqlLogger syslog handling decoded VariableValue, not the underlying JSON string

    What was broken:

    • Syslog updates from SystemLogLast arrived as VariableValue, but the logger passed that wrapper to json.loads().

    Inputs that triggered it:

    • Any SystemLogLast update routed into SQL logging.

    Result:

    • Valid syslog entries failed to decode and log correctly.

    Fix:

    • Unwrapped the stored string payload before JSON decoding.

Update the SqlLogger class to unwrap JSON payloads from VariableValue objects before decoding syslog entries. This change ensures proper handling of log entries, improving the reliability of the logging functionality within the PyRogue framework.
@ruck314

ruck314 commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

@bengineerd Should be entry.value (instead of entry[])

@bengineerd bengineerd merged commit 80558d1 into pre-release Mar 26, 2026
6 checks passed
@bengineerd bengineerd deleted the bugfix/sql-logger-syslog branch March 26, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants