fix: modernize super() calls in AxiStreamDmaMon#1177
Merged
Conversation
…s in AxiStreamDmaMon Replace deprecated Python 2 super(self.__class__, self) pattern with Python 3 super() in all three AxiStreamDmaMon classes to prevent potential MRO issues with subclassing. Update BuffCount descriptions in Rx and Tx to clarify they are static driver configuration values that do not change at runtime.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes initialization in the AxiStreamDmaMon* device classes by switching to Python 3-style super() calls and clarifies the meaning of BuffCount so users understand it’s a static driver configuration value rather than a runtime-polled metric.
Changes:
- Replace legacy
super(self.__class__, self).__init__(...)withsuper().__init__(...)in Rx/Tx/top-level monitor classes. - Update
BuffCountdescriptions for both Rx and Tx monitors to explicitly state they are static configuration values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bengineerd
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
super(self.__class__, self).__init__()with Python 3super().__init__()in all threeAxiStreamDmaMonclasses to prevent potential MRO infinite recursion with subclassingBuffCountdescriptions in Rx/Tx to document they are static driver configuration values (no polling needed)Test plan
python3 -m compileall -fpasses with zero errorsflake8 --countpasses with zero violations