Skip to content

Attach base statement as child for asTry dumpInfo#2584

Merged
mergify[bot] merged 1 commit into
slick:mainfrom
natefitzgerald:n8f-asTryfix
Oct 21, 2022
Merged

Attach base statement as child for asTry dumpInfo#2584
mergify[bot] merged 1 commit into
slick:mainfrom
natefitzgerald:n8f-asTryfix

Conversation

@natefitzgerald

Copy link
Copy Markdown

The getDumpInfo method of asTry should have the action that is to be tried as a child for logging purposes.

This is my first contribution here, sorry if there's a template I need to be following or something. I created this issue for the problem and this single line is all that's needed for the solution. I am happy to add tests if reviewers think it appropriate but I followed exactly the convention established in CleanUpAction

@lightbend-cla-validator

Copy link
Copy Markdown
Collaborator

@natefitzgerald

Copy link
Copy Markdown
Author

I have signed the CLA

@nafg

nafg commented Oct 20, 2022

Copy link
Copy Markdown
Member

Thanks!

See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

If want to change the email address used in the commit, you may need to do something like this:

git config --local user.email XXXXX && git commit --amend --no-edit --reset-author

where XXXXX is an email associated with your github account, and then force-push the branch.

If you want to avoid exposing your email address read https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address.

@github-actions

Copy link
Copy Markdown
Contributor

There are no incompatible changes

@nafg nafg self-requested a review October 20, 2022 19:17
@github-actions

Copy link
Copy Markdown
Contributor

There are no incompatible changes

@nafg nafg added this to the 3.5.0 milestone Oct 21, 2022
@nafg

nafg commented Oct 21, 2022

Copy link
Copy Markdown
Member

@Mergifyio refresh

@mergify

mergify Bot commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

refresh

✅ Pull request refreshed

@github-actions

Copy link
Copy Markdown
Contributor

There are no incompatible changes

@mergify mergify Bot merged commit 6f8079f into slick:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

asTry should have the original action attached as a child in getDumpInfo

3 participants