fix(export): pass timeout to frame.waitForLoadState() (#2578)

andreas-taranetz · claude · web-flow · commit 36f8a896618c · 2026-05-02T11:16:43.000+08:00
The timeout option was already forwarded to page.goto() and page.waitForLoadState(), but the subsequent frame loop used Playwright's hardcoded 30 s default. Large presentations with many slides, iframes, or complex components could exceed 30 s, making --timeout and export.timeout ineffective. Fixes #2577 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
diff --git a/packages/slidev/node/commands/export.ts b/packages/slidev/node/commands/export.ts
@@ -278,7 +278,7 @@ export async function exportSlides({
     // Wait for frames to load
     {
       const frames = page.frames()
-      await Promise.all(frames.map(frame => frame.waitForLoadState()))
+      await Promise.all(frames.map(frame => frame.waitForLoadState(undefined, { timeout })))
     }
     // Wait for Mermaid graphs to be rendered
     {

Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,7 @@ export async function exportSlides({`
`278`	`278`	`// Wait for frames to load`
`279`	`279`	`{`
`280`	`280`	`const frames = page.frames()`
`281`		`- await Promise.all(frames.map(frame => frame.waitForLoadState()))`
	`281`	`+ await Promise.all(frames.map(frame => frame.waitForLoadState(undefined, { timeout })))`
`282`	`282`	`}`
`283`	`283`	`// Wait for Mermaid graphs to be rendered`
`284`	`284`	`{`