Extend health check startup to 60 minutes, set $SHELL for docker container, and bump the GC memory limit from 500MiB to 2GiB #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Jul 8, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [slskd/slskd](https://slskd.org) ([source](https://github.com/slskd/slskd)) | minor | `0.22.5` -> `0.23.1` | --- ### Release Notes <details> <summary>slskd/slskd (slskd/slskd)</summary> ### [`v0.23.1`](https://github.com/slskd/slskd/releases/tag/0.23.1) [Compare Source](slskd/slskd@0.23.0...0.23.1) #### What's Changed - Fix regression in scripts and webhooks causing json to be missing detail by [@​jpdillingham](https://github.com/jpdillingham) in slskd/slskd#1389 **Full Changelog**: slskd/slskd@0.23.0...0.23.1 ### [`v0.23.0`](https://github.com/slskd/slskd/releases/tag/0.23.0) [Compare Source](slskd/slskd@0.22.5...0.23.0) ### 🎉 Database Migrations (that preserve data!) This release introduces a new system that performs database migrations on existing data ([#​1343](slskd/slskd#1343)), which was necessary to migrate the Transfers database to correct an out of memory issue at startup for users with a large number of transfer records (see [#​1291](slskd/slskd#1291)). Upon first start after upgrading to 0.23.0 the application will apply the initial migration to the Transfers database (`transfers.db`), if there is one. Depending on the system and the amount of data present, this may take a while, and the UI will be inaccessible during the process. Backups of existing databases are taken prior to the start of the process (you can find them in `/data/backups`) and they aren't deleted automatically, so **your historical data is safe**. A feature to add auto deletion after a period of time will come later. In the unlikely event that the process fails to complete successfully, follow the directions in the new [migration docs](https://github.com/slskd/slskd/blob/master/docs/migrations.md), which explain what to do if something goes wrong, and how to get the application back to a working state if the migration can't be completed. If you find that your database can't be migrated successfully, please file an issue and I can work on providing a standalone migration tool. #### What's Changed - Add a system to perform database migrations by [@​jpdillingham](https://github.com/jpdillingham) in slskd/slskd#1343 - Fix remaining transfter State queries using HasFlag() by [@​jpdillingham](https://github.com/jpdillingham) in slskd/slskd#1356 - Extend health check startup to 60 minutes, set $SHELL for docker container, and bump the GC memory limit from 500MiB to 2GiB by [@​jpdillingham](https://github.com/jpdillingham) in slskd/slskd#1359 - Bump Soulseek.NET to 7.1.0 by [@​jpdillingham](https://github.com/jpdillingham) in slskd/slskd#1363 - Update documentation for scripts by [@​jpdillingham](https://github.com/jpdillingham) in slskd/slskd#1384 - Bump http-proxy-middleware from 2.0.6 to 2.0.9 in /src/web by [@​dependabot](https://github.com/dependabot) in slskd/slskd#1329 **Full Changelog**: slskd/slskd@0.22.5...0.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xLjMiLCJ1cGRhdGVkSW5WZXIiOiI0MS4xLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImltYWdlIl19--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/860 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The health check endpoint doesn't work until the app has fully started, which means after migrations have run and the initial scan (if one is needed) has completed. If someone has large shares or a large amount of data to be migrated, the container could go unhealthy and enter a reboot loop before startup is complete.
Setting
$SHELLresolves a warning about it being missing, and enables docker users to write scripts that default to/usr/bin/bashas the executable, where currently they must specify it for each script.Bumping the GC limit should give some extra headroom for folks with a large amount of shares. The app runs fine with 500MiB, but the amount of memory needed to complete a share scan does scale with the number of shares/files. If people find that the container starts abusing memory I'll bump this down to 1 GiB.