Fix bug preventing proper change detection when updating options with an enum type #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It's now a non-issue; I update this property to use a string as a backing type and it's now consistent with the other enum based settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this morning that changing the Soulseek diagnostic level from
InfotoDebugdidn't update the UI or tell me I had to restart. Digging further I found that the 'diff' that is done between the old and new configuration didn't detect the change, and the underlying cause is that the diff logic ignores enum values (rather, tries to traverse them).DiagnosticLevelis the only option that's backed by an enum, so it is the only one affected.