feature: configurable ip address#1555
Conversation
| # - ^.{1,2}$ | ||
| # web: | ||
| # port: 5030 | ||
| # listen_ip_address: 0.0.0.0 |
There was a problem hiding this comment.
| # listen_ip_address: 0.0.0.0 | |
| # ip_address: 0.0.0.0 |
keeping things consistent with the soulseek config; there's no listen_ prefix for the port so there shouldn't be one for the IP either. i can merge to an intermediate branch and take care of this.
|
I will pick this up and get it merged in a bit. Some notes for myself: The current logic uses If a user wanted to listen on just localhost the guidance would be to supply the proper loopback address for their system ( The logic in the kestrel config is then: If the user has specified any value for The only uncovered use case would be instances where the user wanted to listen on multiple, specific addresses but not 'any', in which case another code/config change would be needed. When CIDRs can be supplied for API keys or the relay, they can be supplied as a comma separated list. I suppose this option should have that ability as well. The option will need a custom validator that iterates over the supplied addresses to make sure they are valid. |
(Based on the issue #1083 )
This adds configurable IP address binding for HTTP/HTTPS listeners to support IPv6 and custom network interfaces for example.