Add KnownUnsupportedTypeConverter to prevent crashes when serializing some types#1645
Merged
Conversation
1 task
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Mar 2, 2026
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [slskd/slskd](https://slskd.org) ([source](https://github.com/slskd/slskd)) | patch | `0.24.4` → `0.24.5` | --- ### Release Notes <details> <summary>slskd/slskd (slskd/slskd)</summary> ### [`v0.24.5`](https://github.com/slskd/slskd/releases/tag/0.24.5) [Compare Source](slskd/slskd@0.24.4...0.24.5) ##### What's Changed - Add KnownUnsupportedTypeConverter to prevent crashes when serializing some types by [@​jpdillingham](https://github.com/jpdillingham) in [#​1645](slskd/slskd#1645) - Use shared JsonSerializerOptions when cloning State by [@​jpdillingham](https://github.com/jpdillingham) in [#​1648](slskd/slskd#1648) - Ensure execute bits are set on directory mode by [@​jpdillingham](https://github.com/jpdillingham) in [#​1656](slskd/slskd#1656) - Bump minimatch and eslint-config-canonical in /src/web by [@​dependabot](https://github.com/dependabot)\[bot] in [#​1655](slskd/slskd#1655) - Bump rollup from 2.79.2 to 2.80.0 in /src/web by [@​dependabot](https://github.com/dependabot)\[bot] in [#​1654](slskd/slskd#1654) **Full Changelog**: <slskd/slskd@0.24.4...0.24.5> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNS43IiwidXBkYXRlZEluVmVyIjoiNDMuMjUuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIiwiaW1hZ2UiXX0=--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4333 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not really a crash, but the newer disconnect event has an
Exceptionwhich can't be serialized, so the event wasn't being properly raised. This PR fixes it and hopefully any/all other unsupported type issues with System.Text.Json.