Initialize steppath using a function instead of init #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the initialization of the STEPPATH to an Init function instead of doing it at the start using Go's init function. It also removes the mkdir of STEPPATH. If necessary, commands like "step ca bootstrap" or "step ca init" will create the directory.
hslatman
approved these changes
Jul 26, 2023
This was referenced Jul 26, 2023
I added that initially, but I removed it after not seeing an operation that writes files there that do not do MkdirAll. I can add it back, @hslatman what do you think? |
|
Might be handy to add, just in case, for future use cases. It would make this Given that you mention you didn't find a code path that didn't already do it, it's probably OK to merge this one and add the helper in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit changes the initialization of the STEPPATH to an Init function instead of doing it at the start using Go's init function.
It also removes the mkdir of STEPPATH. If necessary, commands like "step ca bootstrap" or "step ca init" will create the directory.
stepandstep-cashould callstep.Init()at the start and fail if an error is returned. We might need to change other tools too.Commands that create files in the STEPPATH or in a step context should create the directory if it doesn't exist. Main commands like
step ca bootstrapandstep ca initalready do that.