Skip to content

wire: use core::net types for IP addresses. #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dirbaio merged 6 commits into from
Oct 7, 2024
Merged

wire: use core::net types for IP addresses. #994

Dirbaio merged 6 commits into from
Oct 7, 2024

Conversation

@Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Sep 20, 2024

  • wire: move prefix_len impl down to v4 and v6 addrs.
  • wire: use core::net::Ipv4Addr as the ipv4 address type.
  • Bump MSRV to 1.80.

@Dirbaio Dirbaio force-pushed the core-ip branch 4 times, most recently from e57dcc3 to 660efae Compare September 20, 2024 19:32
@thvdveld
Copy link
Contributor

thvdveld commented Sep 25, 2024

I opened rust-lang/libs-team#447, as requested in rust-lang/rust#130629 (comment).

@Dirbaio Dirbaio marked this pull request as ready for review October 6, 2024 21:22
@Dirbaio
Copy link
Member Author

Dirbaio commented Oct 6, 2024 •
edited
Loading

this is ready to review.

I've "fixed" the unstable_name_collisions warnings by renaming the affected methods to x_. it's not pretty but it's the most reasonable solution I think. (note it doesn't affect the public API, the extension trait is private).

I still think we should merge this, moving to the stdlib's ip addr types is worth it even if it requires carrying a few warts internally.

@Dirbaio Dirbaio mentioned this pull request Oct 6, 2024
Merged
@Dirbaio Dirbaio added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 7acf1ac Oct 7, 2024
@Dirbaio Dirbaio deleted the core-ip branch October 7, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thvdveld thvdveld thvdveld approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dirbaio @thvdveld