Collected changes for June 2024 release “Faye” #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eugeneia
commented
May 31, 2024
- apps.mellanox.connectx: alloc_pages(): remove assertion #1518
- Update HTTP/HTTPS IPFIX templates #1522
- Revert raptorjit to use bundled dlmalloc again #1523
Ignore 0 and negative values in alloc_pages(). This assumes that the function is called with the result of query_pages() for which these values are legal (a negative value indicates that pages can be recalimed by the driver). In some versions of the firmware on ConnectX7, query_pages() for "regular" pages during initialization returns a negative value that would trigger the assertion. Allocation of "regular" pages is not part of the card initialization according to the PRM, i.e. this particular problem could also be avoided by removing that call. However, this commit seems more robust. Note that page reclaims are already handled by the event queue through reclaim notifications.
Properly parse the payload according to RFC9112. All valid HTTP 1.1 request methods are now recognized. The parser only considers the first packet with a non-zero payload after a complete TCP handshake.
Find the first packet with non-zero payload after the TCP handshake in a more reliable manner.
Remove duplicate definitions of template keys and values by composing them from common sets of definitions. This changes the order of elements slightly for some templates.
Add a variant of the HTTP template that supports the Flowmon-proprietary IPFIX fields.
Rename v{4,6}_HTTPS to v{4,6}_HTTPS_Flowmon to reflect the fact that
these templates use Flowmon-proprietary IPFIX elements. Also rename
the elements themselves to avoid possible future clashes with
standardized TLS fields.
These templates contain the full extended template in addition to the HTTP/HTTPS elements. This allows extraction of HTTP/HTTPS information without having to copy packets and exporing duplicate flows.
d11ebe287 Merge PR snabbco#268 (Revert "Remove built-in dlmalloc") into next 0fd50d25c Revert "Remove built-in dlmalloc" e5f5a48cc Merge branch 'next' into master git-subtree-dir: lib/luajit git-subtree-split: d11ebe28752ddb3696ca445aa4fbcec6066b52a2
…t-raptorjit-remove-dlmalloc
…assertion) into max-next
…) into max-next
9c6e7c350 Merge pull request snabbco#269 from eugeneia/revert-sysmalloc 07bda5857 unifdef -B -m -f ifdef-defile lj_alloc.c git-subtree-dir: lib/luajit git-subtree-split: 9c6e7c350e3523885d9bff04cd38a78167170c41
… revert-raptorjit-remove-dlmalloc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.