fix: enable default default prefix for source archive upload #3432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 WalkthroughWalkthroughThis update introduces a new optional attribute, Changes
Sequence Diagram(s)sequenceDiagram
participant SS as StorageSettings
SS ->> SS: __post_init__()
alt default_storage_provider is set
SS -->> SS: Set default_storage_protocol = "{default_storage_provider}://"
else
SS -->> SS: default_storage_protocol remains None
end
sequenceDiagram
participant W as Workflow
W ->> W: upload_sources(prefix)
alt prefix is falsy or equals default_storage_protocol
W -->> W: Set prefix = "s3://snakemake-workflow-sources/"
else
W -->> W: Append trailing slash to prefix
end
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (30)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
johanneskoester
requested changes
Mar 14, 2025
| self.remote_job_local_storage_prefix = self.local_storage_prefix | ||
|
|
||
| if self.default_storage_provider: | ||
| self.default_storage_protocol = f"{self.default_storage_provider}://" |
Contributor
There was a problem hiding this comment.
This is dangerous. The name of the provider is not always a valid schema name. We should rather extend the storage provider base class to return the desired schema name via a new abstract method.
| prefix = self.storage_settings.default_storage_prefix | ||
| if prefix: | ||
| if not prefix or prefix == self.storage_settings.default_storage_protocol: | ||
| prefix = "s3://snakemake-workflow-sources/" |
Contributor
There was a problem hiding this comment.
s3:// as a default? Is that intentional?
Contributor
Author
|
yes I will mark as draft and continue to think about a more robust implementation |
Contributor
|
This PR was marked as stale because it has been open for 6 months with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves snakemake/snakemake-executor-plugin-aws-batch#19
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).Summary by CodeRabbit
Summary by CodeRabbit
New Features
Refactor