-
Notifications
You must be signed in to change notification settings - Fork 340
[Simulation] Introduce function to visit mappings according to the mapping graph #5557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alxbilger
wants to merge
11
commits into
sofa-framework:master
Choose a base branch
from
alxbilger:mappingvisit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
[ci-build][with-all-tests] |
Sofa/framework/Simulation/Core/src/sofa/simulation/MappingGraph.h
Outdated
Show resolved
Hide resolved
41b025a to
54637f9
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
bakpaul
reviewed
Oct 22, 2025
bakpaul
approved these changes
Oct 22, 2025
89dd53b to
582f008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: enhancement
About a possible enhancement
pr: status wip
Development in the pull-request is still in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue in SOFA, is that the mappings (
apply,applyJ,applyJTetc) are applied through visitors, which depends on the scene graph. It's up to the user to define the scene graph, and there is a lot of possibilities. In some cases, the user defines a scene graph that does not correspond to the mapping graph, a DAG linking mappings and their input and output.This PR replaces the mapping visitors by a simple function dedicated to the traversal of the mapping graph.
This solution avoids to refactor the visitor mechanism. Only a sub-part of the mechanical operations is affected.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if