Skip to content

Conversation

@alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Jun 24, 2025

An issue in SOFA, is that the mappings (apply, applyJ, applyJT etc) are applied through visitors, which depends on the scene graph. It's up to the user to define the scene graph, and there is a lot of possibilities. In some cases, the user defines a scene graph that does not correspond to the mapping graph, a DAG linking mappings and their input and output.

This PR replaces the mapping visitors by a simple function dedicated to the traversal of the mapping graph.

This solution avoids to refactor the visitor mechanism. Only a sub-part of the mechanical operations is affected.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added the pr: enhancement About a possible enhancement label Jun 24, 2025
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@alxbilger alxbilger added the pr: status to review To notify reviewers to review this pull-request label Jul 3, 2025
@bakpaul bakpaul removed the pr: status to review To notify reviewers to review this pull-request label Sep 24, 2025
@alxbilger alxbilger added the pr: status to review To notify reviewers to review this pull-request label Oct 13, 2025
@alxbilger alxbilger marked this pull request as ready for review October 13, 2025 15:56
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@alxbilger alxbilger added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement About a possible enhancement pr: status wip Development in the pull-request is still in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants