feat: filter grouping multiple workflows by queue-name #120
+529
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the workflow queue filtering mechanism to support searching for queue names across all workflows in the repository, rather than being limited to a single workflow. This improves the flexibility and reliability of the queueing logic in multi-workflow environments.
- Modified the Waiter class to accept and utilize a list of all workflows when filtering by queue name
- Implemented batched workflow run fetching (batch size: 10) to improve efficiency and avoid rate limits
- Enhanced error handling using Promise.allSettled for graceful handling of failed workflow run requests
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/wait.ts | Enhanced queue filtering logic to search across all workflows with batching and error handling |
| src/main.ts | Updated Waiter instantiation to pass the full workflows list |
| package.json | Upgraded vitest dev dependency from ^3.1.4 to ^3.2.4 |
| tests/wait.test.ts | Added comprehensive test coverage for cross-workflow queue filtering behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…develop Signed-off-by: Rui Chen <rui@chenrui.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR enhances the workflow queue filtering mechanism to support searching for queue names across all workflows in the repository, rather than being limited to a single workflow. This improves the flexibility and reliability of the queueing logic, especially in complex repositories with multiple workflows.
Changes
src/main.tsto pass the full list of workflows as an argument.wait.tests.tsto increase code coverage and validate behavior when queueName is definedMotivation
Previously, filtering by queueName only checked runs from a single workflow. In multi-workflow environments, jobs enqueued with the same queue name could be missed. This update ensures all workflows are considered, improving the accuracy of the waiting/queueing mechanism.