Conversation
|
No test? |
|
👍 will add the tests. Just want to make sure the patch fixes the bug first. |
|
works 👍 |
|
Although I am getting this: I'll have to dig more into it, currently on the way to the office, will check in 1/2 an hour. |
|
Thanks for the confirmation! @tamird, added the tests broken on master and fixed on this branch. ptal. |
|
RE: EOF I beleive this is because you're using an http server with a tls config. Instead, we need to create a |
|
@soheilhy that wouldn't work the grpc-gateway :( when I run it: |
|
@kalbasit hmm... I don't have a good answer on why TLS doesn't work for you. I tried a few examples and seems to be working fine. Since this isn't related to this pull request, can you please create another issue with a minimal example to reproduce the bug? Thanks. |
|
@soheilhy agree, I'll investigate more and if I'll make an minimal example if needed. |
|
lgtm |
|
Thanks guys! |
Fix index out of range in patricia tree
Bug #32 reported that there is an index out of range error. This
issue was introduced in 703b087.