impl: gill/kit solana pay #272
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to ecbc920 in 42 seconds. Click for details.
- Reviewed
1593lines of code in19files - Skipped
2files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. corev2/create-sol-transfer.ts:11
- Draft comment:
Unused import: 'getTransferSolInstruction' is imported but not used. Remove it if unnecessary. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. corev2/create-spl-transfer.ts:66
- Draft comment:
Remove commented-out code blocks to keep the file clean and maintainable. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. corev2/parse-url.ts:64
- Draft comment:
Consider using the SOL_DECIMALS constant instead of hardcoding '9' for decimals validation. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. corev2/fetch-transaction.ts:19
- Draft comment:
Double casting with 'as unknown as Transaction' indicates a type mismatch. Consider refining the types or handling the conversion more explicitly. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_yM4WL3Ty1F8Teu4X
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
gitteri
left a comment
There was a problem hiding this comment.
Can you add something to the readme about this addition? there are no docs for this right now.
| export const MEMO_PROGRAM_ID = address('MemoSq4gqABAXKb96qnH8TysNcWxMyWCqXgDLGmfcHr'); | ||
|
|
||
| export const TOKEN_PROGRAM_ID = address('TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA'); |
There was a problem hiding this comment.
These don't seem to be used (memo / token program ids)
| const recipientAddress = address(recipient); | ||
|
|
||
| return [ | ||
| getTransferInstruction({ |
There was a problem hiding this comment.
doesn't look like this works with memos even though they're allowed to be passed in. can you add the memo instruction
| // const recipientATAInfo = await rpc.getAccountInfo(recipientATA).send(); | ||
| // if (!recipientATAInfo.value) { | ||
| // instructions.push( | ||
| // getCreateAssociatedTokenInstruction({ | ||
| // mint: splTokenAddress, | ||
| // tokenProgram, | ||
| // owner: recipientAddress, | ||
| // ata: recipientATA, | ||
| // payer: | ||
| // }) | ||
| // ); | ||
| // } else { | ||
| // const recipientAccount = await fetchTokenAccount(rpc, recipientATA, { programAddress: tokenProgram }); | ||
| // if (!recipientAccount.data.isInitialized) throw new CreateTransferError('recipient not initialized'); | ||
| // if (recipientAccount.data.isFrozen) throw new CreateTransferError('recipient frozen'); | ||
| // } |
There was a problem hiding this comment.
should this be uncommented?
|
As a general suggestion, I think it would make sense to use Looking at your imports, everything you import from Where you import from |
Uh oh!
There was an error while loading. Please reload this page.