Fix incorect check for SPL 2022 in createSPLTokenInstruction #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use .equals() instead of === for PublicKey
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to a31e03d in 27 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. core/src/createTransfer.ts:147
- Draft comment:
Good fix using .equals() to compare PublicKey objects instead of ===. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it only praises the use of.equals()instead of===for comparingPublicKeyobjects. It does not provide any actionable feedback or suggestions for improvement.
Workflow ID: wflow_LVTbO2dLecpsx0af
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should use .equals() instead of === for PublicKey
Important
Fixes incorrect
PublicKeycomparison increateSPLTokenInstructionto ensure correct token program selection.createSPLTokenInstructionincreateTransfer.tsby using.equals()instead of===forPublicKeyobjects.TOKEN_2022_PROGRAM_IDorTOKEN_PROGRAM_ID) is selected based on account owner.This description was created by
for a31e03d. You can customize this summary. It will automatically update as commits are pushed.