Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@behzadnouri
Copy link
Contributor

Problem

packet::send_to sends packets one by one:
https://github.com/solana-labs/solana/blob/9213fcb11/streamer/src/packet.rs#L63-L75

sendmmsg uses a single system call for multiple messages:
https://github.com/solana-labs/solana/blob/9213fcb11/streamer/src/sendmmsg.rs#L94

Summary of Changes

  • use sendmmsg in streamer.

@behzadnouri behzadnouri requested a review from jbiseda February 10, 2022 20:33
Copy link
Contributor

@jbiseda jbiseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jbiseda jbiseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #23062 (4b09283) into master (9213fcb) will increase coverage by 0.0%.
The diff coverage is 75.0%.

@@           Coverage Diff           @@
##           master   #23062   +/-   ##
=======================================
  Coverage    81.2%    81.2%           
=======================================
  Files         564      564           
  Lines      153461   153468    +7     
=======================================
+ Hits       124673   124690   +17     
+ Misses      28788    28778   -10     

@behzadnouri behzadnouri merged commit c078ca3 into solana-labs:master Feb 11, 2022
@behzadnouri behzadnouri deleted the streamer-sendmmsg branch February 11, 2022 13:36
mergify bot pushed a commit that referenced this pull request Feb 11, 2022
packet::send_to sends packets one by one:
https://github.com/solana-labs/solana/blob/9213fcb11/streamer/src/packet.rs#L63-L75

sendmmsg uses a single system call for multiple messages:
https://github.com/solana-labs/solana/blob/9213fcb11/streamer/src/sendmmsg.rs#L94

(cherry picked from commit c078ca3)

# Conflicts:
#	streamer/src/streamer.rs
mergify bot added a commit that referenced this pull request Feb 11, 2022
* uses sendmmsg in streamer (#23062)

packet::send_to sends packets one by one:
https://github.com/solana-labs/solana/blob/9213fcb11/streamer/src/packet.rs#L63-L75

sendmmsg uses a single system call for multiple messages:
https://github.com/solana-labs/solana/blob/9213fcb11/streamer/src/sendmmsg.rs#L94

(cherry picked from commit c078ca3)

# Conflicts:
#	streamer/src/streamer.rs

* removes mergify merge conflicts

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants