This repository was archived by the owner on Jan 22, 2025. It is now read-only.
v1.9: Enforce tx metadata upload to bigtable #23212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b93ebcf to
43aa4dc
Compare
43aa4dc to
0bfa584
Compare
Codecov Report
@@ Coverage Diff @@
## v1.9 #23212 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 530 530
Lines 147975 148032 +57
=========================================
+ Hits 120882 120923 +41
- Misses 27093 27109 +16 |
Contributor
Author
|
This is a manual backport because I won't be backporting earlier changes related to versioned transactions to v1.9. But this fix has already been applied to v1.8 so I think it's appropriate to bring back to v1.9 as well |
CriesofCarrots
approved these changes
Feb 22, 2022
Contributor
CriesofCarrots
left a comment
There was a problem hiding this comment.
Sorry for the delay. lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Transaction status metadata types allow metadata to be None which can cause problems when that metadata is required for RPC requests.
Summary of Changes
Very similar to #23028
allow_missing_metadatacli option from ledger tool uploader because it's impossible for that to happenFixes #