fix: update Makefile with correct paths#1095
Merged
Merged
Conversation
Update Makefile with correct paths so "make uninstall" removes "steamtinkerlaunch.svg" and "steamtinkerlaunch.desktop".
Owner
|
Wow! Thank you for catching those incorrect paths. I'm not sure how this went undetected for so long, you might've saw in the blame that it's been this way since I added this way back in #608. I triple-checked because I could not believe these were wrong. The change to use Thanks a bunch for finding and fixing this. I'll merge it now :-) |
Owner
|
Changelog has been updated to give credit, under the "Fixes" section: https://github.com/sonic2kk/steamtinkerlaunch/wiki/Changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to update the Makefile with correct paths so
make uninstallremoves "steamtinkerlaunch.svg" and "steamtinkerlaunch.desktop". This also removes the unnecessarily-r(recursive) flag, while removing those two files.Testing (before)
Shows two files are left behind after
make uninstall.Testing (after)
Shows no files are left behind after
make uninstall.Thanks!