Skip to content

GameScope: Add Mouse Sensitivity#1026

Merged
sonic2kk merged 4 commits into
masterfrom
gamescope-mouse-sensitivity
Jan 27, 2024
Merged

GameScope: Add Mouse Sensitivity#1026
sonic2kk merged 4 commits into
masterfrom
gamescope-mouse-sensitivity

Conversation

@sonic2kk

@sonic2kk sonic2kk commented Jan 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Owner

GameScope has recently added support for configuring mouse sensitivity with ValveSoftware/gamescope@8783464. This is a decimal value that the base mouse sensitivity is multiplied by. This PR exposes it on our GameScope GUI.

image

This option didn't seem to do anything in my tests, both from the SteamTinkerLaunch GUI and manually with games from the commandline. I am using the right version as the option shows up in --help.

TODO:

  • Further testing
  • Update langfiles
  • Update wiki screenshot

@sonic2kk

sonic2kk commented Jan 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Owner Author

It will go in a seperate PR, but I am going to refactor how we index the arrays. It's getting way too annoying to change each index when we bump an option.

@sonic2kk

sonic2kk commented Jan 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Owner Author

Something strange is going on. When --adaptive-sync is enabled, GSMOUSESENSITIVITY is set to --. Otherwise, it works fine.

Something weird is going on, potentially related to #1024.

@sonic2kk sonic2kk mentioned this pull request Jan 27, 2024
Closed
@sonic2kk

sonic2kk commented Jan 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Owner Author

Weirdness should be fixed with #1027.

In that PR I used the example of -r and --rt, but here the issue is likely related to the -s in --adaptive-sync (-sync -> -s).

@sonic2kk sonic2kk force-pushed the gamescope-mouse-sensitivity branch from 6a7a517 to c23b387 Compare January 27, 2024 03:30
@sonic2kk

sonic2kk commented Jan 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Owner Author

Rebased on master after #1027, fixed an issue where we were trying to compare decimals, and the weirdness is gone.

Game launch works OK in my tests too with this option, and when the option is 1, we correctly ignore it and don't append it to the GameScope arguments. It also seems to have an effect with Steam games, unlike my earlier tests.

I will update the langfiles and bump the version and then merge.

@sonic2kk

sonic2kk commented Jan 27, 2024

Copy link
Copy Markdown
Owner Author

Langfiles updated, version bumped, shellcheck is green, we are ready to merge!

@sonic2kk sonic2kk merged commit a3b9cea into master Jan 27, 2024
@sonic2kk sonic2kk deleted the gamescope-mouse-sensitivity branch January 27, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sonic2kk