Add PGWEB_BOOKMARKS_DIR environment variable#837
Merged
Conversation
…irectory Allow the bookmarks directory to be set via the PGWEB_BOOKMARKS_DIR environment variable, in addition to the existing --bookmarks-dir flag. Priority: CLI flag > env var > default ($HOME/.pgweb/bookmarks). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The go-flags library treats "/" as an option prefix on Windows, causing ParseOptions to misinterpret "/tmp/flag-bookmarks" as a flag. Use t.TempDir() which produces a platform-appropriate temporary directory. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PGWEB_BOOKMARKS_DIRenvironment variable to configure the bookmarks directory, complementing the existing--bookmarks-dirCLI flagPGWEB_*naming convention and integrates withgetPrefixedEnvVar(), which provides backwards-compatible fallback to unprefixedBOOKMARKS_DIRwith a deprecation warning--bookmarks-dirflag >PGWEB_BOOKMARKS_DIRenv var > default$HOME/.pgweb/bookmarksTest plan
go build ./...)PGWEB_BOOKMARKS_DIR=/tmp/bookmarks pgwebuses the specified directory🤖 Generated with Claude Code