Minor fix to Pandeia notebook #126
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandeia changes:
compute_nexp,bracketkeyword is for the range of exposures to test, not magnitude. Also, xtold --> xtol.minimize_scalar,bracketargument is not needed formethod = 'bounded'.compute_nexpmatch those that it returns, to avoid confusion. For example, everywhere in the notebook, we call the ETC outputreport, but in this particular call, it returnsetc. I missed that name change and it took me a little bit to figure it out.eport['scalar']['sn'] < sn: nexp += 1then we need to run the Pandeia calculation again to get an updated total exposure time, otherwise we’re one exposure time short.