Add concurrent option #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
May 4, 2021
| } | ||
|
|
||
| /** @test */ | ||
| public function it_will_execute_the_given_closures_with_concurrency_cap() |
src/Fork.php
Outdated
|
|
||
| $output[$task->order()] = $taskOutput; | ||
| if (count($queue)) { | ||
| $i = array_key_first($queue); |
freekmurze
requested changes
May 4, 2021
Member
freekmurze
left a comment
There was a problem hiding this comment.
Looks nice.
We could opt to extract some things in waitFor to their own functions so it's more clear what it happing there. If it would make it easier, I wouldn't made setting $running as an instance variable.
This reverts commit 0f7e3e8.
Contributor
Author
|
PHP cs is acting up, but I'm going to merge it nevertheless. |
Contributor
Author
|
wrong button >< |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.