Kill any forked tasks when force closed in terminal #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice, thanks! |
|
after this release we start to notice that fork return empty string in a random way function is_server_running(string $ip, int $port = 22, int $timeout = 5): bool
{
$result = command("nc -zv -w$timeout $ip $port 2>&1");
$result = str($result['output'])->lower();
if ($result->contains(['succeeded', 'connected'])) {
return true;
}
return false;
}
[$ssh, $apache, $goservice] = Fork::new()->run(
fn () => is_server_running($server->ip, $server->port, timeout:10),
fn () => is_server_running($server->ip, 80, timeout:10),
fn () => is_server_running($server->ip, config('settings.goservice'), timeout:10)
) ;
dump($ssh);
dump($apache);
dump($goservice);we rollback to 1.2.0 and everything start to work as expected. cc @stevebauman |
Contributor
Author
|
Hey @malohtie, looking into this now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that if you run one or more forked processes and force-terminate the parent running process in the CLI before the child (forked) processes finish, Fork won't terminate the stray running processes, leaving them running in the background.
This PR simply iterates through any running tasks if the CLI command is terminated and kills them via their PID.