Fix fill-in-the-blanks for the object pattern with additional properties #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Resolve conflicts, and merge once done? |
- Ensure that you update the pattern map before calling fill to account for additional properties. - Add test to ensure the behavior
6552f2e to
6e14271
Compare
joelrosario
approved these changes
May 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Fix fill-in-the-blanks for the object pattern with additional properties
Why: Due to a missing call to update additional properties, any extra keys in the payload were being treated as out of spec, even when
additionalPropertieswere defined in theOpenAPIschema.How:
Checklist:
Issue ID:
Closes Issue: #1796