Skip to content

Conversation

@hilloftheking
Copy link
Contributor

This allows for multiple translation units to include tools.hpp
For some reason this already worked properly on GCC, but now it will work on MSVC.

@spnda spnda merged commit 392bd1c into spnda:main Feb 11, 2024
@spnda
Copy link
Owner

spnda commented Feb 11, 2024

After merging I noticed that perhaps some compilers will throw a warning about the function being marked as constexpr inline when FASTGLTF_CONSTEXPR_BITCAST is 1. I can only find a relevant MR from clang-tidy which shows a warning in this case: https://reviews.llvm.org/D18914

If that ever comes up from someone using -Wall or -Werror i'll fix it. Thanks though.

@spnda spnda added enhancement New feature or request done bugfix labels May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants