fix: Rethrow ToolExecutionException for non-RuntimeException #3915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c46a5c3 to
597f8a4
Compare
- If the cause is a non-RuntimeException (e.g., IOException, OutOfMemoryError), rethrow the tool exception. - Update the relevant description in docs Signed-off-by: YunKui Lu <luyunkui95@gmail.com>
597f8a4 to
af30705
Compare
juntae6942
pushed a commit
to juntae6942/spring-ai
that referenced
this pull request
Aug 7, 2025
…projects#3915) Fixes spring-projects#3915 Auto-cherry-pick to 1.0.x - If the cause is a non-RuntimeException (e.g., IOException, OutOfMemoryError), rethrow the tool exception. - Update the relevant description in docs Signed-off-by: YunKui Lu <luyunkui95@gmail.com>
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
…projects#3915) Fixes spring-projects#3915 Auto-cherry-pick to 1.0.x - If the cause is a non-RuntimeException (e.g., IOException, OutOfMemoryError), rethrow the tool exception. - Update the relevant description in docs Signed-off-by: YunKui Lu <luyunkui95@gmail.com>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
…projects#3915) Fixes spring-projects#3915 Auto-cherry-pick to 1.0.x - If the cause is a non-RuntimeException (e.g., IOException, OutOfMemoryError), rethrow the tool exception. - Update the relevant description in docs Signed-off-by: YunKui Lu <luyunkui95@gmail.com>
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
…projects#3915) Fixes spring-projects#3915 Auto-cherry-pick to 1.0.x - If the cause is a non-RuntimeException (e.g., IOException, OutOfMemoryError), rethrow the tool exception. - Update the relevant description in docs Signed-off-by: YunKui Lu <luyunkui95@gmail.com> Signed-off-by: 家娃 <guanjing.pangj@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explain
When users declare a tool using the
@Toolannotation, they might throw a checked exception or an Error exception, like in the example below:Currently, the default behavior of
DefaultToolExecutionExceptionProcessoris to pass checked exceptions and Errors to the AI Mode, which may cause users to fail to detect issues in a timely manner.We should rethrow non-RuntimeException exceptions to remind users to handle them manually, rather than letting the AI Mode deal with them.
By the way (I just learned this too), when we use reflection to invoke a method, if the method throws an Error(no Exception), it will also be caught as an InvocationTargetException.
