Add missing binop and bitwise operators for dynamic type #299
Conversation
- Refactored test_dynamic.py to organize tests into test_binop, test_cmp, and test_bitwise - Implemented arithmetic operators: -, /, //, % - Implemented bitwise operators: <<, >>, &, |, ^
antocuni
left a comment
There was a problem hiding this comment.
@bttglc LGTM, thank you.
I'm curious, though: did you do it "manually" or you used some LLM/code assistant?
I'm asking mostly because the style in the description looks very similar to what I get from claude from time to time.
Just to be clear: it's fine to use LLMs, I'm just curious.
|
Thank you! I was unsure on what the best practice to write PRs is since this is my very first one, so I did indeed use an LLM to write the list of changes in the text above. Would you prefer it to be avoided or at least specified next time? |
That's a good question. As humans, we are still learning what are the best practices around LLMs. Again, you didn't do anything wrong :) |
|
Makes sense! I'll modify the text according to what emerged in this exchange and next time I'll write if and how I've used an LLM more clearly :) |
Summary
dynamictype #291Changes
test_dynamic.pyto organize tests intotest_binop,test_bitwiseandtest_cmp(following the pattern used intest_int.py)dynamictype:-,/,//,%dynamictype:<<,>>,&,|,^_dynamic_opforruntime type checking
w_modabovew_divinopimpl_int.py, since that's the order they appear in elsewhere.Notes
I went ahead and worked on the issue before getting assigned; I hope that's not a problem.
Happy to make any changes based on your feedback! Thanks in advance.
[Summary and Changes generated via
claude-code].