Promote google/protobuf/api.proto as a runtime proto #3187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this includes its dependencies. This is useful for people who want to define a path on their RPCs.
JakeWharton
approved these changes
Nov 27, 2024
Collaborator
JakeWharton
left a comment
There was a problem hiding this comment.
I don't know what this means but if you want a green checkmark I am your guy
Member
Author
|
Protobuf exposes option so that someone can embed the path of an RPC in the proto schema like so rpc MyRpc (MyRequest) returns (MyResponse) {
option (google.api.http) = {
post: "/cash/my-path"
};
}Before this PR, people wanting to use this option would have to manually add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this includes its dependencies. This is useful for people who want to define a path on their RPCs without having to load protobuf on their proto path manually.