Fallback to package version from optional deps #119
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're attempting to install @duckdb/node-bindings@1.4.1-r.4, which has the various os/arch flavours listed as optional dependencies. We need it to install @duckdb/node-bindings-linux-arm64@1.4.1-r.4, but can't add that to our project's dependencies without it throwing a big error when we attempt to run `pnpm install` on our non-linux dev machines. By falling back to reading from the optionalDependencies, we can list @duckdb/node-bindings-linux-arm64@1.4.1-r.4 in our optionalDependencies and have SST install that specific version at deploy time instead of defaulting to '*' (the latest version) like it does now. Co-authored-by: John Cadigan <jcad@sibipro.com>
✅ Deploy Preview for sst-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're attempting to install
@duckdb/node-bindings@1.4.1-r.4, which has the various os/arch flavors listed as optional dependencies.We need it to install
@duckdb/node-bindings-linux-arm64@1.4.1-r.4, but can't add that to our project's dependencies without it throwing a big error when we attempt to runpnpm installon our non-linux dev machines.By falling back to reading from the optionalDependencies, we can list
@duckdb/node-bindings-linux-arm64@1.4.1-r.4in ouroptionalDependenciesand have SST install that specific version at deploy time instead of defaulting to*(the latest version) like it does now.