use packages=external in build scripts #416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR modernizes the build scripts across all packages to use Bun's packages: "external" option instead of manually listing dependencies to externalize. The primary motivation was fixing a bug in the core package where regular dependencies (yoga-layout, diff, jimp, bun-ffi-structs) were being bundled because the old code only externalized optionalDependencies and peerDependencies.
Key changes:
- Removed manual dependency listing code that gathered dependencies from package.json
- Switched to Bun's
packages: "external"option for automatic npm dependency externalization - Retained special external patterns in core package for non-npm files (WASM, SCM files)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/vue/scripts/build.ts | Removed manual dependency collection and switched to packages: "external" |
| packages/solid/scripts/build.ts | Removed manual dependency collection and switched to packages: "external" |
| packages/react/scripts/build.ts | Removed manual dependency collection and switched to packages: "external" for all three build targets |
| packages/core/scripts/build.ts | Removed manual dependency collection, added --packages=external CLI flag, and updated comments while preserving special external patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Need to run some tests first with opencode builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build scripts were manually listing dependencies to externalize, but core was missing regular
dependencies(only hadoptionalDependenciesandpeerDependencies). This caused deps likeyoga-layout,diff,jimp, andbun-ffi-structsto be bundled into dist.Switched all packages to use Bun's
packages: "external"option which automatically externalizes all npm imports.Tested compiling examples to standalone binaries with
bun build --compile- yoga-layout WASM and other dependencies are still bundled correctly by Bun at compile time.