-
-
Notifications
You must be signed in to change notification settings - Fork 682
Add case studies section to the marketing site with monday.com's case study #8956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
server/lib/tuist_web/marketing/components/marketing_layout_components/navbar.html.heex
Show resolved
Hide resolved
fortmarek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
I've also noticed we have "Case studies" in the "Blog" but the new posts don't appear there. Also, the category has, for whatever reason a hyphen there:
I know it's in the design, but I find the "What monday.com does..." too off center. For the time being, I'd consider skipping it, I don't think having that title is needed and we can reconsider it once @asmitbm is back:
I find the title too long. Should we have a short title and with a subtitle like regular blog posts?
Additionally, have we thought about putting the case study more front-and-center in the landing page, such as by making the customers section be a link to case studies?
server/lib/tuist_web/marketing/components/marketing_layout_components/navbar.html.heex
Show resolved
Hide resolved
server/lib/tuist_web/marketing/live/marketing_case_studies_live.html.heex
Outdated
Show resolved
Hide resolved
server/lib/tuist_web/marketing/live/marketing_case_studies_live.html.heex
Show resolved
Hide resolved
| margin-block-end: 0; | ||
| } | ||
|
|
||
| .sr-only { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this class name confusing. What is it for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Claude making the case study page more accessible, and suggested using that class in a [link](https://github.com/tuist/tuist/pull/8956/changes#diff-73a995584be83adf5660e8a991f2bc76e798e28308c434cf59960252bc1cb2d0R410 in the case studies page to indicate screen readers that the link opens in a new tab.
I'm not too opinionated about it, so I'm also fine with removing it.
| def case_studies_rss(conn, _params) do | ||
| cases = CaseStudies.get_cases() | ||
| last_build_date = cases |> List.first() |> Map.get(:date) | ||
|
|
||
| conn | ||
| |> assign(:cases, cases) | ||
| |> assign(:last_build_date, last_build_date) | ||
| |> render(:case_studies_rss, layout: false) | ||
| end | ||
|
|
||
| def case_studies_atom(conn, _params) do | ||
| cases = CaseStudies.get_cases() | ||
| last_build_date = cases |> List.first() |> Map.get(:date) | ||
|
|
||
| conn | ||
| |> assign(:cases, cases) | ||
| |> assign(:last_build_date, last_build_date) | ||
| |> render(:case_studies_atom, layout: false) | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we want to have another RSS for case studies. Case studies are basically special pieces of blog posts and I think we should try to model them more like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you expand on what modeling them like blog posts means to you? Is it that they should show up in the RSS & Atom of the blog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it that they should show up in the RSS & Atom of the blog?
That and I would expect them to show up in the blog page as well: https://tuist.dev/blog
I suggest we move this one to case studies once we have an open-graph card design for it. I can follow-up with Trendyol with suggestion to align it with the structure we'd like case studies to have.
I'll skip it then.
I can shorten the title. Regarding the subtitle, I'm fine with that. We have a excerpt that we use in the HTML for SEO, so we can reuse it. I suggest that we ship the design as it is, and tackle these improvements once @asmitbm is back and can help us iterate on the design.
Same here. I'll capture this in a task for @asmitbm to design when he's back. |
33e3e00 to
6180468
Compare
fortmarek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| use NimblePublisher, | ||
| build: Tuist.Marketing.CaseStudies.CaseStudy, | ||
| from: Application.app_dir(:tuist, "priv/marketing/case_studies/*.md"), | ||
| as: :cases, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| as: :cases, | |
| as: :case_studies, |
would probably rename this and the get_cases method to get_case_studies
We are going to start publishing case studies of customers so existing users or teams interested in Tuist don't have to take our word for the impact that our solutions have.