fix coroutine panic: replace ended_coroutine Bitfield with vec #4177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrocarlo
approved these changes
Dec 11, 2025
Contributor
pedrocarlo
left a comment
There was a problem hiding this comment.
I don't see a problem with it. I imagine the tests failures are due to something else
pereman2
approved these changes
Dec 11, 2025
314158c to
216f4d7
Compare
pedrocarlo
approved these changes
Dec 11, 2025
Contributor
|
with thiis fix i'm getting this error after hang/waiting.. for few mins, ig we r slow., but i would assume this is a sim bug not this pr, i would take a look at thsi evening when i get back. also note that we might have to consider adding before fix: after this fix: |
Contributor
update: it is a sim bug not db. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4146
Motivation and context
panics are bad
AI Disclosure
none used