Connection small refactor #4187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes further refactoring easier given the code length
Instead of manually getting the inner connection everytime with locking and error handling add a new function and call it. Also replaces the one instance of an unwrap with an expect as per project preferences
This is needed for the Connection pool so that when a Connection is dropped we can take the inner connection and put it back into ConnectionPool
I wanted to be sure I hadn't broken clone
LeMikaelF
approved these changes
Dec 12, 2025
Removed commented-out code for clarity.
Use .to_string instead of format!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connection has grown to the point where a separate module to make future refactoring easier makers sense.
Replaced manually getting the inner connection with all the locking/error handling with a utility method. This will be handy for the ConnectionPool work
Motivation and context
Foundation work for the ConnectionPool and removing an unwrap
AI Disclosure
None